-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing missing support for "Subcategory Levels" parameter in contacts category view #41618
Fixing missing support for "Subcategory Levels" parameter in contacts category view #41618
Conversation
Add the missing support for `maxLevel` parameter in contacts category view.
Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/69748/1/8 |
Yeah, but what is it complaining about. The lack of alignment between |
I have tested this item ✅ successfully on 696b25d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618. |
@Quy Do you know why the test is failing? |
This pull request has been automatically rebased to 5.1-dev. |
@HLeithner Do you know why this issue fails build? Its a bug that affects one of clients websites and I see no reply to the question. |
I updated the branch, this should retrigger a ci run |
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on 8ececc4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41618. |
Thanks |
This adds the support for
Subcategory Levels
inCategory
tab ofList Contacts in a Category
view. Currently, this setting is not applied in the query, so using it will not allow viewing all contacts in the category and its subcategories.Summary of Changes
Added state entry and query filter for this parameter.
Testing Instructions
All contacts
A
and set the parent asAll contacts
B
and set the parent asAll contacts
Contact from A
and place it inA
categoryContact from B
and place it inB
categoryList Contacts in a Category
, chose categoryAll contacts
and make sure inCategory
tabSubcategory Levels
is set toAll
or any positive valueActual result BEFORE applying this Pull Request
There should be no contacts displayed in this view.
Expected result AFTER applying this Pull Request
All contacts from category
A
andB
will be displayed.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed